Closed espkk closed 1 year ago
@espkk can you remove "jobs": 8
? I think that all has different HW and CI has less then 8 cores.
@espkk can you remove
"jobs": 8
? I think that all has different HW and CI has less then 8 cores.
CI should override thread count with the actual number of cores
Ok. What about people that have 4-6 or 24 cores? I tested on my old Windows PC with 4 cores and this looks wrong:
Ok. What about people that have 4-6 or 24 cores? I tested on my old Windows PC with 4 cores and this looks wrong:
It should be possible to override with the -j
flag. 8 is an informal default for -j
The problem is that we already have msvc parallel build enabled, so it should be already optimal. While parallel project building increases contention
I'm not sure yet if we can disable it for windows builds only without introducing a new build preset, but since so far it's only used for windows builds, we can just disable it completely
UPD: I removed "jobs": 8
and got better results:
It's still 4-6 threads, but it's not 8 at least.
@q4a, check my previous answer. in worst case it might be cores x 8 on windows
PS don't merge this yet, let me squash
should be fine now