feat: new package structure with src dir, vitest, deps updates, revamped actions and more

storyblok / storyblok-react

React SDK for Storyblok CMS

MIT License

123 stars 37 forks source link

feat: new package structure with src dir, vitest, deps updates, revamped actions and more #1267

Open edodusi opened 1 week ago

edodusi commented 1 week ago

Updated according the new structure, with src instead of lib and new defaults.

Notes

Workspaces: moved everything under pnpm workspaces
Cypress: folder and config moved to root dir, component tests in __tests__ but needs rework (TBD)
- default e2e runsa agains the Next13 App Router playground
Vitest: added an initial test in __tests__, need more tests
Playgrounds: now we have react, next13, next13 app router and next 15
GH Actions: refactored and updater, added commitlint, separate test
TypeScript: upgraded to esnext modules, config revamp but left ES2015 as target (let's check this)

How to test

Create a new project with React or Next and import the module using the latest commit provided here. You can use the playgrounds as reference.

pkg-pr-new[bot] commented 1 week ago

Open in Stackblitz

pnpm add https://pkg.pr.new/@storyblok/react@1267

commit: b21ce42

edodusi commented 3 days ago

hey @alvarosabu, I used feat in the title because when we merge this we will squash and I think a minor version upgrade will be ideal, because we are not only refactoring directories or linting but we are actually updating core dependencies (storyblok/js and nextjs) and changing the build so once we merge this the build output will be different, and I think this requires a new release with a minor version (I think you typed major but were thinking minor)

Then I added many commits but we will just squash them so no need to worry about the semantic release.

alvarosabu commented 1 day ago

hey @alvarosabu, I used feat in the title because when we merge this we will squash and I think a minor version upgrade will be ideal, because we are not only refactoring directories or linting but we are actually updating core dependencies (storyblok/js and nextjs) and changing the build so once we merge this the build output will be different, and I think this requires a new release with a minor version (I think you typed major but were thinking minor)

Then I added many commits but we will just squash them so no need to worry about the semantic release.

Hey @edodusi thanks for clarifying, I missed the core deps bump since the other package.json was on the lib directory so I didn't see the diff. It makes sense to do a feat then since next increased a major and there are changes on the build output. Im gonna proceed to download and to QG.

Keep you posted