search

storybookjs / repro-templates

WIP
2 stars 4 forks source link

[Bug] When opening a Stackblitz link, it gets stuck forever #2

Open oscard0m opened 2 years ago

oscard0m commented 2 years ago

Describe the bug

When opening a Stackblitz link it takes forever. Since other Stackblitz links are working I'm assuming is something not on Stackblitz's end.

Tried with:

Steps to reproduce the behaviour

  1. Just open one of the links in README.md

Expected behaviour

To immediately open a repo template environment in Stackblitz

Screenshots and/or logs

This is the screen where it gets stuck: image

oscard0m commented 2 years ago

UPDATE: Seems to be something related to Stackblitz:

cra (main) image

html (main) It works now

cra (next) image

EricSimons commented 2 years ago

Hi- Eric from StackBlitz here. It looks like the CRA templates in the GitHub repo don't have a package.json in them nor any actual application code within them, which is what's causing this issue. See here: https://github.com/storybookjs/repro-templates/tree/main/cra

oscard0m commented 2 years ago

Hi- Eric from StackBlitz here. It looks like the CRA templates in the GitHub repo don't have a package.json in them nor any actual application code within them, which is what's causing this issue. See here: https://github.com/storybookjs/repro-templates/tree/main/cra

Thanks @EricSimons, let's see what Storybook team says about it.

In their branch: next there is a package.json but it still fails. Do you think it's a different issue?

https://github.com/storybookjs/repro-templates/tree/next/cra https://stackblitz.com/github/storybookjs/repro-templates/tree/next/cra?preset=node image