deprecate @storybook/vue in 7.6

storybookjs / storybook

Storybook is the industry standard workshop for building, documenting, and testing UI components in isolation

https://storybook.js.org

MIT License

84.73k stars 9.33k forks source link

deprecate @storybook/vue in 7.6 #24779

Open vanessayuenn opened 1 year ago

vanessayuenn commented 1 year ago

Vue2 reaches EOL on 2023-12-31, and we will remove support for it in Storybook in 8.0. Ahead of that, we should deprecate @storybook/vue in 7.6

Tasks

[x] write up rationale for deprecating @storybook/vue as an RFC in GitHub discussion
[ ] deprecate @storybook/vue in 7.6 and point to 👆 the discussion

vanessayuenn commented 1 year ago

@shilman to decide on whether to deprecate package or to warn user (and how)

shilman commented 1 year ago

Let's deprecate @storybook/vue in 7.6. This is the loudest signal of what's to come. The deprecation warning should point to a GH discussion where we explain the rationale for removing Vue2 support in 8.0. This also gives us a chance to reverse the decision before 8.0 if we're missing something.

vanessayuenn commented 1 year ago

alright i updated the issue to capture the actual work needed.

@shilman will you write the rationale RFC? Sounds like we cannot do the deprecation without the link to point it to. @yannbf I supposed it makes sense to assign it to the next empathy person, in this case @ndelangen.

yannbf commented 11 months ago

Here's the link to the RFC: https://github.com/storybookjs/storybook/discussions/24951

cc @JReinhold (currently on empathy)

JReinhold commented 11 months ago

Because we need to keep releasing 7.X versions of the packages, the packages will automatically get undeprecated - a newly released version is not automatically deprecated.

Therefore we need to:

[x] Remove the packages from next so they don't get published in 8.0 prereleases. Storyshots have already been removed, but we need to remove vue, vue-vite and vue-webpack5.
[ ] ~Update all PRs with next so canaries don't publish anymore of the packages too.~
[ ] At the end of the publishing workflow, deprecate the packages again, so that when 7.6.Y is released, the packages are deprecated again.
[ ] Get 👆 on main as well.

vanessayuenn commented 11 months ago

At the end of the publishing workflow, deprecate the packages again, so that when 7.6.Y is released, the packages are deprecated again.

[ ] Get 👆 on main as well.

@JReinhold So we need to keep doing this until 8.0 is out of prerelease, right?

JReinhold commented 11 months ago

@vanessayuenn yes unless we add it as a script at the end of every publish. That was my original intent but we never got that far