Closed yannbf closed 1 year ago
For anyone interested (cc @shuda323, @AlmarAubel, @mikiSumcul, @mrtnvh, @MichaelBitard, @Hanawa02, @i-udas), please follow this PR and test its canary version.
It's currently in version 1.0.0-canary.13.922565e.0
, however with typescript issues for now (so ignore that part for now)
Feedback is deeply appreciated!
@SocketSecurity ignore-all
Hi,
Thanks for your work!
We have tried this PR --> https://github.com/MTES-MCT/camino/pull/621/files#diff-1e6de3828ce1525bbc845baedb2831cd210cf0284863af1f7bbb618fc555c825
and we only have the *.ts
storybook files failing, all our *.tsx
storybook files work well
Hi,
Thanks for your work!
We have tried this PR --> https://github.com/MTES-MCT/camino/pull/621/files#diff-1e6de3828ce1525bbc845baedb2831cd210cf0284863af1f7bbb618fc555c825
and we only have the
*.ts
storybook files failing, all our*.tsx
storybook files work well
Thank you so much @MichaelBitard, your reproduction was crucial to get this in the right shape. The most recent version should work with JSX and non-JSX stories: 1.0.0-canary.13.54193a7.0
, there's only one last step to get this 100%, which is the Typescript types!
New, updated, and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: @babel/core@7.12.9, @cypress/vue@3.0.1, @cypress/webpack-dev-server@1.3.0, @storybook/addon-actions@6.2.9, @storybook/addons@6.2.9, @storybook/client-api@6.2.9, @vue/cli-plugin-typescript@4.5.13, @vue/cli-service@4.5.13, @vue/compiler-sfc@3.0.11, babel-loader@8.2.2, cypress@7.4.0, vue-loader@15.9.7
You're welcome, thanks to you for doing all this! I was merely an alpha-tester :)
I updated our PR with your latest version and it works for tsx and ts files \o/.
I just had to add a function check if (typeof value.story === 'function') {
here https://github.com/MTES-MCT/camino/pull/621/files#diff-1e6de3828ce1525bbc845baedb2831cd210cf0284863af1f7bbb618fc555c825R43 to make typescript happy
You're welcome, thanks to you for doing all this! I was merely an alpha-tester :)
I updated our PR with your latest version and it works for tsx and ts files \o/.
I just had to add a function check
if (typeof value.story === 'function') {
here https://github.com/MTES-MCT/camino/pull/621/files#diff-1e6de3828ce1525bbc845baedb2831cd210cf0284863af1f7bbb618fc555c825R43 to make typescript happy
Thanks once again <3 I believe I fixed all issues now, it's shippable and you wouldn't need any workaround. Could you please do a final test?
1.0.0-canary.13.c3b6b8a.0
hell yeah \o/ It's perfect!
@MichaelBitard thanks once again, v1.0.0 is released!
This is a followup work on #12 as I couldn't push to the branch unfortunately. Original work by @i-udas
Closes #3, Closes #8, Closes #10, Closes #11
What I did
Release Notes
Support Storybook 7.0 (#13)
💥 Breaking Change
This version adds support for Storybook 7.0. It requires you to be using Storybook 7.0, as there were several internal changes required, all of which depend on new Storybook packages.
🚀 Features
In Storybook 7.0, the play function can also be defined in the Meta (default export). This is now supported in
@storybook/testing-vue3
.Additionally, this package also supports CSF3, while maintaining compatibility with previous formats as well such as CSF1 and CSF2.
⚠️ Deprecations
The
setGlobalConfig
function is now deprecated in favor ofsetProjectAnnotations
, which aligns better with Storybook 7.0 nomenclature.From:
To:
The future of @storybook/testing-vue3
This package served as a way to provide testing utilities for Vue + Storybook users, and after some validation it's a candidate to be promoted into the
@storybook/vue3
package itself. Meaning, in the near future, the utilities of this package will be merged into@storybook/vue3
and the@storybook/testing-vue3
package will be deprecated, given that you won't need yet another package anymore. This should happen in the upcoming months.Once this is done, there will be a final release notifying the users, and the migration should be simple and straightforward. Thank you so much for using this package!
📦 Published PR as canary version:
1.0.0-canary.13.c3b6b8a.0
:sparkles: Test out this PR locally via: ```bash npm install @storybook/testing-vue3@1.0.0-canary.13.c3b6b8a.0 # or yarn add @storybook/testing-vue3@1.0.0-canary.13.c3b6b8a.0 ```