search

storyprotocol / protocol-core-v1

core protocol repo for mainnet launch
Other
84 stars 66 forks source link

M-1 tagDerivativeIfParentInfringed() function may use outdated arbitration policy for the IP #286

Open rvierdiiev opened 1 month ago

rvierdiiev commented 1 month ago

Description

IP can set any whitelisted arbitration policy to itself. The policy will be updated after cool-down period.

When derivative is disputed with tagDerivativeIfParentInfringed() function, then its policy is fetched directly from $.arbitrationPolicies.

As IP can set any whitelisted arbitration policy to itself after cool-down period, the value fetched in tagDerivativeIfParentInfringed() function may be outdated.

Recommendation

Add _updateActiveArbitrationPolicy() function at the beginning of tagDerivativeIfParentInfringed() to update policy.

TheMarvelFan commented 1 month ago

Hi,

I would like to contribute to this issue if no one else is working on it.

Thanks!

Spablob commented 2 weeks ago

Hi,

I would like to contribute to this issue if no one else is working on it.

Thanks!

Hi sir, sorry for the delay in the response. We thank you for the interest in contributing.

Feel free to open a PR for this issue.

TheMarvelFan commented 2 weeks ago

@Spablob please review the PR and let me know if further modifications are required.

Thanks!