search

strands-project / strands_navigation

Higher-level navigation capabilities
41 stars 48 forks source link

Move topological_rviz_tools somewhere else? #386

Closed hawesie closed 4 years ago

hawesie commented 4 years ago

i suspect a few people want to use topological_rviz_tools without many of the packages int this repo. I suggest we move it to its own repo either under strands, lcas or ori-goals. Any thoughts @heuristicus @marc-hanheide ?

heuristicus commented 4 years ago

I think it would make sense if it lives in https://github.com/LCAS/topological_navigation, since you need those components for it to work. Although perhaps as a user interface component it would be sensible to separate it.

Jailander commented 4 years ago

I think that for release purposes it is a lot easier if it is hosted either in here or in https://github.com/LCAS/topological_navigation, I would argue that since the toponav repo is the one with more active maintenance maybe it makes sense to move it there. @heuristicus if you decide for the move, it would be nice to move it with all the commit history I am happy to help you with it.

heuristicus commented 4 years ago

Sure, if you have any tips on moving the directory it would be useful, since I don't think I've done it before. My initial guess would be to add strands_navigation as a remote in topological_navigation, then cherry-pick all commits that happened on files in the topological_rviz_tools directory. Perhaps that's a naive approach that wouldn't work.

Something like: https://stackoverflow.com/questions/19821749/git-cherry-pick-or-merge-specific-directory-from-another-branch

marc-hanheide commented 4 years ago

I already wondered why @Jailander hadn't included the rviz tools into topological_navigation. I think that's where they should be.

marc-hanheide commented 4 years ago

And @heuristicus is right, that's the preferred way to keep the commit history.

hawesie commented 4 years ago

So, we're all for the move to topological_navigation in LCAS then. Excellent.

heuristicus commented 4 years ago

PR here: https://github.com/LCAS/topological_navigation/pull/8

heuristicus commented 4 years ago

PR for removal in strands_navigation at https://github.com/strands-project/strands_navigation/pull/387

Jailander commented 4 years ago

I already wondered why @Jailander hadn't included the rviz tools into topological_navigation. I think that's where they should be.

Hi because I only moved the ones I am mostly the maintainer :sweat_smile: , but in hindsight...