search

strapi-community / jekyll-strapi

Jekyll plugin to retrieve content from any Strapi API.
https://strapi.io
MIT License
57 stars 30 forks source link

add support for api v4 collection #19

Closed mkrajewski90 closed 2 years ago

mkrajewski90 commented 2 years ago

The response for api v4 collection is different than from the previous versions. I've made a temporary fast fix, but I think this code should be streamlined.

Current changes:

Mcastres commented 2 years ago

Hello @mkrajewski90 👋 Thanks for this contribution! The thing is that this repository is not maintained anymore so I'm not sure about what we should do here. Are you a Ruby developer?

mkrajewski90 commented 2 years ago

@Mcastres - thank you for your feedback.

The thing is that this repository is not maintained anymore so I'm not sure about what we should do here.

I've thought that contributors can give me a feedback and merge changes eventually. I think it might be a good idea to make a v4 branch with changes related to this version and backward versions support and after finish it - merge to master and change the library version.

Are you a Ruby developer?

Yes, I am.

Mcastres commented 2 years ago

Sounds great. Should I create a v4 branch then?

asmirbe commented 2 years ago

i'm still getting an error with your code /jekyll/strapi/drops.rb:33:in to_liquid': undefined methodeach' for nil:NilClass (NoMethodError)

oDinZu commented 2 years ago

I tested this code and it didn't work for me either on Jekyll 4.2.2.

{{ strapi.collections.posts.size }} gives me 0 results.

bluszcz commented 2 years ago

Hello @mkrajewski90 👋 Thanks for this contribution! The thing is that this repository is not maintained anymore so I'm not sure about what we should do here. Are you a Ruby developer?

Does it mean that this project/plugin is dead? :(

bluszcz commented 2 years ago

@Mcastres hello, could you please let us know in some transparent way what are the plans with this repo? I believe that there is some part of community which wold profit from having updated this gem. Do you plan somehow to maintain the plugin, or to give it back to community maintenance, or shall we fork it to death and maintain on our own? :) Any feedback would be appreciated. Thx.

Mcastres commented 2 years ago

Sure @bluszcz, don't worry I didn't forget this topic :) I have a call today 3:30 PM CET with derrickmehaffy to see how we can transfer this repo to the community org if possible though and have you and other contributors join the org. I'll keep you posted

bluszcz commented 2 years ago

@Mcastres Happy to hear it. Having this jekyll-strapi unblocke we could help release Strapi with Jekyll to wider oceans ;)

bluszcz commented 2 years ago

Hello @mkrajewski90 - my 0,2cents :) I think there is no point to maintain an api for an older (<4) version. I am not sure if there is an interest in Strapi 3 community to have new features from Jekyll-Strapi (like auth etc). And if someone would like to use version 3 for some reason, they can download older version of jekyll-strapi. What do you think?

Mcastres commented 2 years ago

@bluszcz, are you on our Discord?

I started a conversation for you to join the strapi-community organization where we can potentially migrate the repository for you to maintain it. Channel: co-general under the Strapi Community Organization category. Would you be the only person interested in maintaining it?

mkrajewski90 commented 2 years ago

Hello @mkrajewski90 - my 0,2cents :) I think there is no point to maintain an api for an older (<4) version. I am not sure if there is an interest in Strapi 3 community to have new features from Jekyll-Strapi (like auth etc). And if someone would like to use version 3 for some reason, they can download older version of jekyll-strapi. What do you think?

Hey, sorry to not answer here last weeks - I've been busy. I've just written you an e-mail, I also look at this topic next week, I hope.

bluszcz commented 2 years ago

@Mcastres I am on Discord - will try to join today to mentioned channel. I think I can start with access for myself and @mkrajewski90, since it seems we may be aligned in the vision.

@mkrajewski90 - I received email from you BTW, thanks :)

bluszcz commented 2 years ago

@bluszcz, are you on our Discord?

I started a conversation for you to join the strapi-community organization where we can potentially migrate the repository for you to maintain it. Channel: co-general under the Strapi Community Organization category. Would you be the only person interested in maintaining it?

bluszcz#1077 would be my discord username, I believe.

mkrajewski90 commented 2 years ago

I tested this code and it didn't work for me either on Jekyll 4.2.2.

{{ strapi.collections.posts.size }} gives me 0 results.

Check the api response in the browser, before changing permissions I didn't see too.

/jekyll/strapi/drops.rb:33:in to_liquid': undefined methodeach' for nil:NilClass (NoMethodError)

Can you give us a case study what's wrong?