strapi-community / jekyll-strapi

Jekyll plugin to retrieve content from any Strapi API.
https://strapi.io
MIT License
57 stars 30 forks source link

Strapi favicon loading behind custom favicon #28

Closed oDinZu closed 2 years ago

oDinZu commented 2 years ago

ffmpeg -i input_video_file.mp4 output.gif

strapi-favicon-v4 1 11-2022-7-5

strapi version: v4.1.11

oDinZu commented 2 years ago

Ok, thanks to Strapi amazing :1st_place_medal: support + Derrick super awesome sauce.

All you need to do is replace the favicon.ico in the root of the project, then rebuild the app.

We have figured out why this is happening. I added images to: ./strapi-app/ src/admin/extensions then, added this to my: ./strapi-app/src/admin/app.js

...
        //replace favicon with custom icon
        head: {
            favicon: favicon,
        },
...

The instructions here on Strapi docs entails us to replace the favicon without replacing root favicon.ico https://docs.strapi.io/developer-docs/latest/development/admin-customization.html#configuration-options

derrickmehaffy commented 2 years ago

Ok, thanks to Strapi amazing 1st_place_medal support + Derrick super awesome sauce.

All you need to do is replace the favicon.ico in the root of the project, then rebuild the app.

We have figured out why this is happening. I added images to: ./strapi-app/ src/admin/extensions then, added this to my: ./strapi-app/src/admin/app.js

...
        //replace favicon with custom icon
        head: {
            favicon: favicon,
        },
...

The instructions here on Strapi docs entails us to replace the favicon without replacing root favicon.ico https://docs.strapi.io/developer-docs/latest/development/admin-customization.html#configuration-options

Can you open an issue on our documentation repo about this one? Because those docs are absolutely wrong, sorry about that!