search

strapi / design-system

Strapi.io's design system :rocket:
https://design-system.strapi.io
MIT License
472 stars 166 forks source link

feat : add new svg icons for "xls", "zip" and "csv" #1814

Closed mukulpadwal closed 2 weeks ago

mukulpadwal commented 2 weeks ago

What does it do?

Adds three new icons ("xls," "zip," and "csv") from the Phosphor icon library to enhance file-type representation. The icons are named FileXls, FileZip, and FileCsv to standardize naming.

Why is it needed?

These icons are required for upcoming improvements in the Media Library, allowing users to better identify specific file types.

How to test it?

Storybook Verification : Check the Storybook instance for the icon library. The new icons should be visible along with other icons, as shown in the screenshot.

Screenshot 2024-11-06 104630

Related issue(s)/PR(s)

This update addresses part of the requirements outlined in Issue #1813

changeset-bot[bot] commented 2 weeks ago

🦋 Changeset detected

Latest commit: c1be9e20428d1f29635d5fd51094cd48e13bf15c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages | Name | Type | | --------------------- | ----- | | @strapi/icons | Minor | | @strapi/design-system | Minor | | @strapi/ui-primitives | Minor |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

vercel[bot] commented 2 weeks ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
design-system ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 7, 2024 4:05pm
lucasboilly commented 2 weeks ago

Hey @mukulpadwal, thanks a lot, it's all good from a design point of view!

I'll let @remidej approve the code part 🙂