strapi / design-system

Strapi.io's design system :rocket:
https://design-system.strapi.io
MIT License
472 stars 166 forks source link

fix: icon color not changing on hover for links #1826

Closed mukulpadwal closed 2 days ago

mukulpadwal commented 3 days ago

What does it do?

Fixes the hover behavior for link icons by applying the correct color to both text and SVG paths. Updated styles to use color for text and fill for SVG paths.

Why is it needed?

The link icon color did not change on hover due to incorrect style rules. This fix ensures consistent hover feedback for better user experience.

How to test it?

  1. Navigate to the Link component in the Storybook design system site.
  2. Hover over the link to observe the color change.
  3. Verify that both the text and the SVG icon change to the desired primary color on hover.

Additionally, a video has been attached for visual reference, showcasing the changes and the expected behavior.

https://github.com/user-attachments/assets/b27d30df-6dd3-4f85-8d65-0082159cb7da

Related issue(s)/PR(s)

Fixes #1825

changeset-bot[bot] commented 3 days ago

🦋 Changeset detected

Latest commit: 25bba2fc31687f3aff6e2df69f8ea30a9d25737b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages | Name | Type | | --------------------- | ----- | | @strapi/design-system | Minor | | @strapi/icons | Minor | | @strapi/ui-primitives | Minor |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

vercel[bot] commented 3 days ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
design-system ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 20, 2024 11:20am
lucasboilly commented 2 days ago

That's perfect @mukulpadwal 👌