strapi / strapi

πŸš€ Strapi is the leading open-source headless CMS. It’s 100% JavaScript/TypeScript, fully customizable, and developer-first.
https://strapi.io
Other
64k stars 8.15k forks source link

Sharp below v0.33 requires a build environment #22235

Open LunaticMuch opened 1 week ago

LunaticMuch commented 1 week ago

Bug report

Required System information

Describe the bug

In the current strapi version, the package @strapi/upload uses sharp. Sharp requires some additional binaries which are either built locally or pulled from github. This causes troubles when strapi is being install in a corporate environment where a private registry and there's no direct access to internet and/or the proxy blocks the download of binaries.

Steps to reproduce the behavior

In a corporate environment just make a yarn install

Expected behavior

The install should work smoothly without requiring extra pull of binaries from github. This is fixed using sharp v0.33.5

Additional context

There's a thread on sharp

derrickmehaffy commented 1 week ago

Hey @LunaticMuch would you be willing to open a PR on this one?

LunaticMuch commented 1 week ago

Hey @LunaticMuch would you be willing to open a PR on this one?

Done already πŸ˜„ https://github.com/strapi/strapi/pull/22237