Restructure `Roles` as a prepration for integration tests

jbesraa commented 3 months ago

This is the first stage of #1120

While trying to add integration tests we noticed that the roles logic should have a bit of refactor, mainly moving some of the library logic out of main.rs to lib folder/file in order to make it nicely accessible via testing.

Currently we have four different roles we want to refactor

[x] Translator - #1092
[x] JDServer - #1095
[x] JDClient - #993
[x] Pool - #1097
[x] MiningDevice - https://github.com/stratum-mining/stratum/pull/1163
[ ] Sv1 Mining Device - https://github.com/stratum-mining/stratum/issues/1245

Example for such change covering the Translator role https://github.com/stratum-mining/stratum/pull/1092/files

Goals:

Get the roles code structured in a way that they can be composable inside the new integration test framework.
Avoid breaking current behavior of roles. After this refactoring, it’s important that all roles continue passing the current MG test stack, and can also be launched manually while following the expected behavior.

plebhash commented 3 months ago

@jbesraa should we list https://github.com/stratum-mining/stratum/pull/993 on the issue description for the JDClient bullet point?

and given that #993 has already been merged, should we close #992?

jbesraa commented 2 months ago

Added MiningDevice to the list above and a corresponding PR

Edit: not sure if it should be part of this list actually

GitGab19 commented 1 month ago

Can we close this issue now that #1163 has been merged? @jbesraa @plebhash

jbesraa commented 1 month ago

Can we close this issue now that #1163 has been merged? @jbesraa @plebhash

Yup all done here

stratum-mining / stratum

Restructure `Roles` as a prepration for integration tests #1093