strawberry-graphql / strawberry-django

Strawberry GraphQL Django extension
MIT License
391 stars 115 forks source link

refactor: Use graphql-core's collect_sub_fields instead of our own implementation #537

Closed bellini666 closed 4 weeks ago

bellini666 commented 4 weeks ago

This allows us to simplify our optimizer implementation, and also paves the way for nested optimizations implementation in the near future.

codecov-commenter commented 4 weeks ago

Codecov Report

Attention: Patch coverage is 98.18182% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 88.63%. Comparing base (7d1f12f) to head (fc4560f). Report is 1 commits behind head on main.

Files Patch % Lines
strawberry_django/optimizer.py 98.18% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #537 +/- ## ========================================== + Coverage 88.61% 88.63% +0.02% ========================================== Files 41 41 Lines 3462 3433 -29 ========================================== - Hits 3068 3043 -25 + Misses 394 390 -4 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.