search

streamnative / pulsar-archived

Apache Pulsar - distributed pub-sub messaging system
https://pulsar.apache.org
Apache License 2.0
72 stars 25 forks source link

ISSUE-15667: `topicName` should not be a `required` config for source connector #4238

Open sijie opened 2 years ago

sijie commented 2 years ago

Original Issue: apache/pulsar#15667

Describe the bug For some of the source connectors, like debezium connector, it actually not sending any messages to the topicName. And the topicName cannot be null: https://github.com/apache/pulsar/blob/branch-2.10/pulsar-functions/utils/src/main/java/org/apache/pulsar/functions/utils/SourceConfigUtils.java#L296-L298

But from the java instance, if no topic is provided, it will use PulsarSinkDisable instead.

We should remove the strict validation on topicName for the source connector.

To Reproduce Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior A clear and concise description of what you expected to happen.

Screenshots If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

Additional context Add any other context about the problem here.

freeznet commented 2 years ago

slack thread: https://streamnative.slack.com/archives/C02PN8TM8HF/p1651244367912909