streamnative / terraform-provider-pulsar

Terraform provider for managing Apache Pulsar entities
Apache License 2.0
43 stars 35 forks source link

fix source/sink connector archive/packageURL support #95

Closed nlu90 closed 1 year ago

nlu90 commented 1 year ago

(If this PR fixes a github issue, please add Fixes #<xyz>.)

Fixes #94

(or if this PR is one task of a github issue, please add Master Issue: #<xyz> to link to the master issue.)

Master Issue: #

Motivation

  1. TF cannot work with pulsar package URL source:// sink:// "function://"
  2. builtin connectors are not handled correctly

Modifications

Describe the modifications you've done.

Verifying this change

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

Verified results:

Documentation

Check the box below.

Need to update docs?

github-actions[bot] commented 1 year ago

@nlu90:Thanks for your contribution. For this PR, do we need to update docs? (The PR template contains info about doc, which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)

github-actions[bot] commented 1 year ago

@nlu90:Thanks for providing doc info!