search

streem / pbandk

Kotlin Code Generator and Runtime for Protocol Buffers
MIT License
271 stars 37 forks source link

Update package mapping to include wildcards #232

Closed Dogacel closed 2 years ago

Dogacel commented 2 years ago
  1. Release kotlin_package_mapping option and document it.
  2. Update package mapping logic to include wildcards.
Dogacel commented 2 years ago

@garyp can I get some reviews?

garyp commented 2 years ago

@Dogacel Thanks for the reminder, sorry I forgot about this PR! I'll take a look today.

FYI, the unit tests seem to be failing on the generateProtos task: https://github.com/streem/pbandk/actions/runs/3394982031/jobs/5646142583.

Dogacel commented 2 years ago

Looks like the unit tests are still failing. Let me know if you need a second set of eyes to figure out why.

I am trying to understand what's happening but have no clue. The following files are generated for some reason:

    conformance/lib/src/commonMain/kotlin/com/
    protoc-gen-pbandk/lib/src/commonMain/kotlin/com/
    runtime/src/commonMain/kotlin/com/
    test-types/src/commonMain/kotlin/com/
    test-types/src/commonMain/kotlin/pbandk/testpb/java/

Whenever I revert changes in buildSrc/src/main/kotlin/KotlinProtocTask.kt they are gone.

Let me revert that change inside that file, for now, and open a separate PR.