search

streem / pbandk

Kotlin Code Generator and Runtime for Protocol Buffers
MIT License
271 stars 37 forks source link

feature: Added mingwX64 and mingwX86 native targets #258

Closed deepthought-64 closed 2 months ago

deepthought-64 commented 7 months ago

I've seen a couple of people (myself included) want to use mingw as Kotlin/Native target to build applications that execute under windows. See https://github.com/streem/pbandk/issues/251, https://github.com/streem/pbandk/issues/233 and https://github.com/streem/pbandk/issues/229

After reading @garyp's comment (https://github.com/streem/pbandk/issues/233#issuecomment-1278355568) it sounded like an easy task.

I have added the mingwX64() and mingwX86() as kotlin targets to build.gradle.kts for modules

@garyp: please advise if that is all that is required

garyp commented 2 months ago

pbandk got updated to Kotlin 2.0.10, so we can now support mingwX64 without setting up CI to run on Windows. I tried adding mingwX64 support to the conformance/lib and conformance/native projects, as I had suggested earlier. But it turns out that protobuf does not support running conformance tests on Windows yet, so adding support for it on the pbandk side is useless for now.

@deepthought-64 Thanks for putting up this PR. I updated it to the current master branch and merged it as #276, so I'll close this PR.