streetcomplete / StreetComplete

Easy to use OpenStreetMap editor for Android
https://streetcomplete.app
GNU General Public License v3.0
3.81k stars 349 forks source link

Check bus stops for existence when no route serves them #5186

Closed BalooUriza closed 1 year ago

BalooUriza commented 1 year ago

General

Affected tag(s) to be modified/added: highway=bus_stop Question asked: Does this bus stop still exist?

Checklist

Checklist for quest suggestions (see guidelines):

Ideas for implementation

Element selection: Bus stops that ARE NOT a member of a bus route relation.

Metadata needed: Has not been recently checked.

Proposed UI: A simple picker of Yes, No, or Can't Say.

Yes adds a check date. No deletes the bus stop. Can't Say offers to create a note or hide.

rhhsm commented 1 year ago

What about areas where bus stops are mapped, but bus routes not (yet)?

Helium314 commented 1 year ago

This may have difficulties in some areas where bus stops exist, but are not signed in any way (not sure where, but I think it came up in some discussion on this issue tracker).

And possibly there is also the bus stopping location that should be removed too if there is no bus stop.

What about areas where bus stops are mapped, but bus routes not (yet)?

Then I would assume the user answers yes to the question whether the bus stop exists.

mnalis commented 1 year ago

What about areas where bus stops are mapped, but bus routes not (yet)?

Then I would assume the user answers yes to the question whether the bus stop exists.

But how would that answer be tagged? @BalooUriza says "Yes adds a check date", but element selection does not mention check date, so the quest would just pop up immediately (not only for that user but also all other users).

Perhaps it might work if Element selection was upgraded to instead be:

Bus stops that ARE NOT a member of a bus route relation and the element is older than 3 years

... or whatever value sound reasonable lifetime of an average bus stop (i.e. how often to re-check if bus stop still exists). That way answering "yes" would skip that quest for few years (when it would be re-asked, unless someone added it to the relation in the meantime. But much better than asking the quest again immediately after it was asked!)

Additional things to consider:

rhhsm commented 1 year ago

There must be statistics on which % of bus stops are part of a route relation in various parts of the world? I suspect that in the evolution of mapping an area, bus stops are mapped much earlier than bus routes. In an area where mapping has just begun, not even bus stops are mapped. As mapping advances, most bus stops added will not be part of a route relation for a long time, and here checking their existence would be very spammy and useless. As mapping approaches completion, most bus stops are likely to be part of a route relation, and here it makes sense to check their existence (or at least increase their existence checking frequency).

mnalis commented 1 year ago

statistics on which % of bus stops are part of a route relation in various parts of the world

Overpass could be used probably (but it might fail for too big areas?); e.g. https://wiki.openstreetmap.org/wiki/Overpass_API/Overpass_API_by_Example#Find_all_bus_stops_which_are_not_included_in_a_relation

westnordost commented 1 year ago

Anyway, I am closing this as per @rhhsm's first comment as I do not see this can be solved. Removing only the platform but not the stop position would be an incomplete change/fix.

BalooUriza commented 10 months ago

What about areas where bus stops are mapped, but bus routes not (yet)?

Then I would assume the user answers yes to the question whether the bus stop exists.

But how would that answer be tagged? @BalooUriza says "Yes adds a check date", but element selection does not mention check date, so the quest would just pop up immediately (not only for that user but also all other users).

Perhaps it might work if Element selection was upgraded to instead be:

Bus stops that ARE NOT a member of a bus route relation and the element is older than 3 years

... or whatever value sound reasonable lifetime of an average bus stop (i.e. how often to re-check if bus stop still exists). That way answering "yes" would skip that quest for few years (when it would be re-asked, unless someone added it to the relation in the meantime. But much better than asking the quest again immediately after it was asked!)

I like that, though based on my experience watching various transit agencies, probably closer to 6 months would be a good lead out time. Like no relation and hasn't been checked/changed in at least 6 months would be a good criteria.

Additional things to consider:

* does it **really happen that often** to be worth of quest (_"no spam"_)? Over here bus stops disappear only very rarely; and besides the capital and an odd city or two, many bust stop do not have relations mapped. So in most of the Croatia that would likely be _spammy_.

But, how many bus stops are not part of a route?