mnalis
commented
2 hours ago TL;DR: I think it is fine as it is...
Improves Usability: A clear, intuitive visual cue (the "X" close icon) helps users understand how to close the menu easily after it’s opened.
That makes absolute sense if you need to click on that icon to close.
But AFAIK, you can click anywhere outside the window to close it if you want to back out. (In fact, that overlay icon is the only place you should not click if you want to exit overlay window, as it will close and then immediately respawn the same window)
Note that all other UI of StreetComplete functions on the principle on "click outside the window to close it" - e.g. after clicking + in Things overlay, of after long pressing to open notes/track/otherapp submenu, or when clicking undo button, or when clicking main hamburger button, or when activating team mode, or when quest is open, or when you click on Uh... quest menu, or when you select Can't say answer, or when you are adding or updating a note, etc...
You exit all of them by clicking outside of displayed window. (or pressing back button / gesture)
So if that behaviour were to be changed, it would have to be changed everywhere to be consistent.
Given that current UI is superior for small screens (no extra space needed for close icon), simpler to implement (no special icons not handlers needed), more usable when using single hand (easier to reach any one of dozens regions, than a specific single button at specific position), more usable for "big thumbs" or people with fine motor control issues (bigger areas are easier to hit), and also common in android UI (e.g. clicking outside of Android launcher group_of_app also closes it), I personally don't see the benefit of changing the UI.
Implementing this feature will significantly improve the navigation experience and make the interface more intuitive.
There is a truism saying that only intuitive thing is mother's tit, and everything else is learned at some point later. :smileycat:
I personally don't recall many android apps which have such "X button at the place of original button"_; most employ other UIs. (in fact, such UI reminds me mostly of HTML5 mobile webpage hamburger menu, and extremely rare in native Android apps - at least the ones that I happen to use)
Feature Description:
Currently, the user can open the menu by clicking the button next to the hamburger menu icon, but there is no clear visual indication for closing the menu once it's opened. To enhance usability and improve the user experience, I propose adding a feature that toggles a close icon (X) when the menu is opened. the problem for example when user is already on surfaces and does not want to change there is no close button he need to click on the screen to remove the contents, sometimes if he click somewhere where did not wanted to click it get's annoying
When the user clicks the same button, the menu should close, and the icon should revert back to its original state.
We can use MUI to implement this feature:
import CloseIcon from '@mui/icons-material/Close';Screenshots:
Why It’s Needed:
Improves Usability: A clear, intuitive visual cue (the "X" close icon) helps users understand how to close the menu easily after it’s opened.
Consistency: It aligns with standard UI patterns where a toggle button shows both open and close states, providing a seamless interaction flow.
Enhanced User Experience: This feature eliminates confusion, ensuring users can close the menu effortlessly with a single button click.
Implementing this feature will significantly improve the navigation experience and make the interface more intuitive.