streetwriters / notesnook

A fully open source & end-to-end encrypted note taking alternative to Evernote.
https://notesnook.com/
GNU General Public License v3.0
10.36k stars 639 forks source link

Prevent editing of notes until sync is finished #3858

Closed streetwriters[bot] closed 2 months ago

streetwriters[bot] commented 1 year ago

making changes to a note causes MERGE CONFLICT if there is a different version of note found upon syncing.

short:

add a feature that prevents editing a note before sync is finished

Device information: App version: 2.6.10-a101dbd-desktop OS: Windows 10 64-bit Browser: Electron 25.9.3 Pro: false

thecodrr commented 1 year ago

add a feature that prevents editing a note before sync is finished

That would be extremely cumbersome. A conflict is only triggered when 2 changes to the same note are more than 1 minute apart. The problem with preventing editing is that you are not always going to edit a note that you already edited on another device. Secondly, this would completely destroy the UX.

I think the best way to avoid this is for the user to wait until changes have synced after opening the app. I know this sounds worse than "automatic edit prevention" for your specific use case but it also allows users to make edits & create new notes without any blocking/prevention whatsoever.

Lastly, the whole point of a conflict is to prevent data loss. The ideal case would be to have everything automatically synced in the background so you don't have to wait after opening the app (we are working on this). But even without that, triggering a conflict is not end of the world and actually allows preserving edits from both devices.

I hope this clarifies our position on this issue.