stride3d / stride

Stride (formerly Xenko), a free and open-source cross-platform C# game engine.
https://stride3d.net
MIT License
6.65k stars 957 forks source link

fix: (Partial) Resolve seg. fault when Graphics API is OpenGL #2189 #2466

Closed Jklawreszuk closed 1 month ago

Jklawreszuk commented 2 months ago

PR Details

PR is fixes crashing when UIPage component with Button is being added. However it requires OpenGL 4.3+ Considering Steam Survey ~90% of Graphics Cards support DirectX 12 should also support OpenGL 4.6, so this is not a big problem for Desktop. Note: This patch only fixes problems with OpenGL. When it comes OpenGL ES, it still may not work because of different instructions

Related Issue

Types of changes

Checklist

Jklawreszuk commented 2 months ago

Any thoughts ? Anyone?

Eideren commented 2 months ago

This is outside my area of expertise sadly, hopefully @xen2 or @tebjan can chime in

Jklawreszuk commented 1 month ago

I am closing because I probably found proper the solution :)