search

strimzi / strimzi-kafka-bridge

An HTTP bridge for Apache Kafka®
Apache License 2.0
286 stars 119 forks source link

Fixed wrong metrics "path" tag by using a custom tags provider #922

Closed ppatierno closed 3 months ago

ppatierno commented 3 months ago

This PR is a workaround for #921 to revert back having the HTTP resource path in the path metrics tag instead of the complete URI (even together with the host and query parameters) as used by latest Vert.x versions. It's also related to the issue https://github.com/vert-x3/vertx-micrometer-metrics/issues/225 I opened on the Vert.x micrometer repo to get why they changed this way.

ppatierno commented 3 months ago

Yeah, I raised the PR just to make people aware of what was going to be a potential workaround. We can wait for them of course but tbh if they are not going to fix that I am not sure the path tag provided by Vert.x is right. The HTTP resource path has its own meaning and it should not contain host and query parameters. So let's see how the discussion goes with them. My feeling is that they went this way because the commit change also moved from HttpServerRequest to use HttpRequest and this one doesn't expose path() but just uri(). Maybe they just didn't notice the implication of that. I think we should not change our dashboards but fixing the code (with them or by ourselves).

ppatierno commented 3 months ago

As per discussion on #921 I am going to close this PR. We prefer to have it fixed on dashboards or properly by Vert.x folks (still waiting for their answer).