search

strimzi / strimzi-kafka-bridge

An HTTP bridge for Apache Kafka®
Apache License 2.0
286 stars 119 forks source link

[#434] feat: added create topic endpoint #927

Closed ilkerkocatepe closed 1 month ago

ilkerkocatepe commented 2 months ago

This PR resolves issue https://github.com/strimzi/strimzi-kafka-bridge/issues/434

First of all, I am very sorry for the delay. From now on, I will make sure to take a task when I can complete it quickly.

ilkerkocatepe commented 2 months ago

Hello @ppatierno, I have an issue with build docs, do you have an idea regarding fix it?

ppatierno commented 2 months ago

Hello @ppatierno, I have an issue with build docs, do you have an idea regarding fix it?

@ilkerkocatepe we have issues with swagger2markup. Some of its dependencies are disappeared from JCenter (and I also read that JCenter was dismissed by JFrog and all calls are redirected to Maven Central). I am investigating about a replacement for swagger2markup (maype using openapi-generator) but it's not there yet, so the build problem with doc is expected right now. I am sorry.

ilkerkocatepe commented 2 months ago

Hello @ppatierno, I have an issue with build docs, do you have an idea regarding fix it?

@ilkerkocatepe we have issues with swagger2markup. Some of its dependencies are disappeared from JCenter (and I also read that JCenter was dismissed by JFrog and all calls are redirected to Maven Central). I am investigating about a replacement for swagger2markup (maype using openapi-generator) but it's not there yet, so the build problem with doc is expected right now. I am sorry.

thank you @ppatierno could you review the pr?

ppatierno commented 1 month ago

@ilkerkocatepe other than taking a look at the comments I left, you could rebase against the main. We have fixed the build documentation related issue (now using a new maven plugin).

ppatierno commented 1 month ago

@ilkerkocatepe I see you rebased but building the doc failed with this ...

ERROR: Uncommitted changes in documentation:
M   documentation/book/api/.openapi-generator/openapi.json-generate-apidoc.sha256
M   documentation/book/api/index.adoc
Run the following to add up-to-date resources:
  make docu_api \
    && git add documentation/book/ \
    && git commit -s -m 'Update generated documentation'

Of course this is because you are changing the OpenAPI spec so the new openapi-generator is generatic a new index.adoc (with a different SHA) which you didn't push. There is no need to push them now even because, as agreed, you are going to change the OpenAPI spec again so remember just to push the new above files when the new implementation is done.

ilkerkocatepe commented 1 month ago

@ppatierno I finished the implementation that we have agreed. Could you check again if it's okay? I pushed new doc files but it's conflicted

ppatierno commented 1 month ago

@ilkerkocatepe did you rebase against main before pushing your changes?

ppatierno commented 1 month ago

@ilkerkocatepe I see the PR in a little mess ... I don't think you changed 58 files :-D It contains all the other commits coming from my fix on the bridge doc and they should not be there. You should fix this first (I think the conflict will go away) and then I can properly review. Thanks!

ilkerkocatepe commented 1 month ago

@ilkerkocatepe did you rebase against main before pushing your changes?

of course but something went wrong :( I'm gonna open a clear pr :)