stripe / stripe-react-native

React Native library for Stripe.
https://stripe.dev/stripe-react-native
MIT License
1.29k stars 262 forks source link

Question about Apple Pay ShippingAddressFields type #641

Closed fbredius closed 2 years ago

fbredius commented 3 years ago

Shouldn't the type of requiredShippingAddressFields? be AddressFields (defined on line 11)? Since currently the type is ContactFieldsType, which to me doesn't really makes sense.

https://github.com/stripe/stripe-react-native/blob/04abc26fcbd43da0c0132d5fbde17567e0bd0117/src/types/ApplePay.ts#L65

charliecruzan-stripe commented 2 years ago

The ContactFieldsType is correct- see Apple's docs: https://developer.apple.com/documentation/passkit/pkcontactfield

huwmartin commented 2 years ago

Is there any way to specify that only postal code should be required similar to billingAddressConfig.format: 'MIN' for Google Pay?