strongbox-password-safe / Strongbox

A KeePass/Password Safe Client for iOS and OS X
https://strongboxsafe.com
GNU Affero General Public License v3.0
1.29k stars 100 forks source link

Autofill Password with TouchID needs extra click in macos Safari #760

Closed ericmoret closed 5 months ago

ericmoret commented 5 months ago

I am facing an issue with native Safari password autofill. This only happens when the password prompt on a separate page from the login. The first time, focus is given to the password field, the contextual menu showing the touchID option is not present. However when I click the key icon within the field, I do see the touchID menu entry popping up. See screenshots. Screenshot 2024-01-30 at 7 13 04 AM Screenshot 2024-01-30 at 7 13 22 AM Screenshot 2024-01-30 at 7 13 36 AM

strongbox-mark commented 5 months ago

Unfortunately this isn't something under our control, this is an Apple thing, the menu and the little icon is Apple GUI/Code until you select a suggestion. That's when Strongbox comes in.

ericmoret commented 4 months ago

I don't disagree that this may not directly be under Strongbox's control. However could it be possible that Apple's widget times out and does not display the expected icon when pulling from a third party provider as opposed to the native iCloud backend? If that was the case, could it be fixed by somehow optimizing the speed of the Strongbox backend?

strongbox-mark commented 4 months ago

I don't think that Apple's widget is timing out here, that's not it. The suggestions are stored in a system database (I believe it's a SQLite database under the hood). There's no direct connection/communication or contact with Strongbox to display these suggestions. Strongbox will be suspended or terminated anyway, not available to communicate with in the background (this is enforced on iOS, and tricky/awkward on macOS anyway).

Strongbox, when it unlocks a one of your password database updates the systems AutoFill suggestions database. Safari or other Apps, use System AutoFill which queries that AutoFill suggestions database. This will be super fast, I've never seen it take more than a few milliseconds.

Just seems like some kind of display issue, best to raise with Apple.