search

studioespresso / craft-scout

Craft Scout provides a simple solution for adding full-text search to your entries. Scout will automatically keep your search indexes in sync with your entries.
MIT License
81 stars 54 forks source link

Fix for elements not being deindexed when indexRelations config is false and queue is enabled #307

Closed mike-moreau closed 4 months ago

mike-moreau commented 5 months ago

When the indexRelations config is set to false and the queue is used, the DeindexElement queue job is not reached in the before delete element event.

This results in the element not be deindexed in Algolia.

Removing the return here ensures the queue job gets pushed.

janhenckens commented 5 months ago

Thanks for catching that! I'll make sure this gets release in the Craft 4 & 5 versions - I'm away on holiday at the moment so it could be another week or 2 before I get the fix out.

janhenckens commented 4 months ago

Thanks @mike-moreau, this fix is included in today's release (4.1.1)