Update textdomain - Githubissues

studiopress / genesis-connect-woocommerce

Core plugin for developing WooCommerce integration

18 stars 14 forks source link

Update textdomain #39

Open dreamwhisper opened 6 years ago

dreamwhisper commented 6 years ago

If your plugin is hosted on wordpress.org it must be the slug of your plugin URL (wordpress.org/plugins/).

https://developer.wordpress.org/plugins/internationalization/how-to-internationalize-your-plugin/#text-domains

screen shot 2018-08-07 at 4 04 23 pm

https://translate.wordpress.org/projects/wp-plugins/genesis-connect-woocommerce

nickcernis commented 6 years ago

👍 As part of this we should also:

Update all 'gencwooc' text domain strings to 'genesis-connect-woocommerce', such as those in https://github.com/copyblogger/genesis-connect-woocommerce/blob/develop/admin/views/html-notice-needs-woocommerce.php.
Change 'requires at least' in the readme from 3.3 to 4.6 (or add load_plugin_textdomain): https://developer.wordpress.org/plugins/internationalization/how-to-internationalize-your-plugin/#loading-text-domain

I checked the logs from WP Slack's #meta-language-packs channel, and they just say:

Plugin is not compatible with language packs: Missing text domain in header.

(It's not clear why it fails on this, though, because the text domain header is optional since 4.6: https://developer.wordpress.org/plugins/internationalization/how-to-internationalize-your-plugin/#text-domains. It may be because we don't specify 4.6 as the minimum version, or it might be that the WP.org warning needs to be updated. Suggest we just add the text domain header anyway for now.)