search

stweil / OSXvnc

VNC Server for macOS
GNU General Public License v3.0
209 stars 69 forks source link

RFB handshake doesn't follow specs anymore #9

Closed aliaoca closed 8 years ago

aliaoca commented 8 years ago

This commit

https://github.com/stweil/OSXvnc/commit/f66b29943ef93b5944b166640cf7424354b73a1b

took out the newline character from the RFB handshake, but it's supposed to still terminate with /n as per the official specs here:

https://tools.ietf.org/html/rfc6143#section-7.1.1

stweil commented 8 years ago

Thank you for your report. This explains why the latest version could not connect to some clients.

The bug is fixed with commit https://github.com/stweil/OSXvnc/commit/ea4d5089a209bbeafc6bcaf802aec6d5615ffcec. More modifications are needed in OSXvnc-server/main.c which uses the macro rfbProtocolVersionFormat in a wrong way.

aliaoca commented 8 years ago

You're very welcome! :)

Do you happen to have a timeline for the next minor release? I'd like to start using some of the new features that you've put in, but the VNC client I'm using doesn't like the current handshake.

If you'd be kind enough to make a new branch with the modifications to OSXvnc-server/main.c I can probably just build the application locally in the meantime as well.

Thanks!

stweil commented 8 years ago

Maybe you can try the new release 5.0.1. Currently I have no plans to add a new branch – all development and fixes are committed to the master branch. Of course it is possible to add a 5.0 branch at any time if that is needed.

aliaoca commented 8 years ago

Using the new release works for me 👍 thanks for getting it out so quickly!

stweil commented 8 years ago

Thanks for testing – so I can close this issue.