supersonic inlet profile

su2code / SU2

SU2: An Open-Source Suite for Multiphysics Simulation and Design

https://su2code.github.io

Other

1.36k stars 843 forks source link

supersonic inlet profile #2326

Closed ShukaiWang1110 closed 4 months ago

ShukaiWang1110 commented 4 months ago

Proposed Changes

This is a draft pull request for the implementation of a supersonic inlet profile feature. the uniform temperature, pressure, and velocity at the inlet for a supersonic inlet BC will replaced with vertex values.

Related Work

Modifications to related codes, recompelling it and doing proper tests using supersonic cases. Iterations.

PR Checklist

[ ] I am submitting my contribution to the develop branch.
[ ] My contribution generates no new compiler warnings (try with --warnlevel=3 when using meson).
[ ] My contribution is commented and consistent with SU2 style (https://su2code.github.io/docs_v7/Style-Guide/).
[ ] I used the pre-commit hook to prevent dirty commits and used pre-commit run --all to format old commits.
[ ] I have added a test case that demonstrates my contribution, if necessary.
[ ] I have updated appropriate documentation (Tutorials, Docs Page, config_template.cpp), if necessary.

ShukaiWang1110 commented 4 months ago

Hi, hope you guys can take a look to see if I am on the right track. Now the compelling error shows it appears that the compiler cannot find the variables Inlet_Temperature, Inlet_Pressure and Inlet_Velocity. This means that we need to declare and define these variables in the appropriate places in the class. Need I declare these variables in the CEulerSolver class and the CFVMFlowSolverBase class?

ShukaiWang1110 commented 4 months ago

SU2ERROR.txt Hi, I followed your comment and now it shows some errors when compelling the code... I copied the error. Do you guys have any ideas

ShukaiWang1110 commented 4 months ago

Well, I noticed some errors and trying to debug now...

ShukaiWang1110 commented 4 months ago

Okay good news is the recompelling is good. looking forward to do some tests.

joshkellyjak commented 4 months ago

SU2ERROR.txt Hi, I followed your comment and now it shows some errors when compelling the code... I copied the error. Do you guys have any ideas

I guess you have already solved but flow dir is a vector that you are trying to divide by a scalar

ShukaiWang1110 commented 4 months ago

SU2ERROR.txt Hi, I followed your comment and now it shows some errors when compelling the code... I copied the error. Do you guys have any ideas

I guess you have already solved but flow dir is a vector that you are trying to divide by a scalar

Yes you're right.

pcarruscag commented 4 months ago

The changes are too confusing to propose changes on GitHub. I'll fix this for you this weekend.

ShukaiWang1110 commented 4 months ago

Sorry Pedro. I basically made the changes on VSCode and copied it to GitHub. I should directly work on here. Thanks for the help, really appreciate it!