su2code / SU2

SU2: An Open-Source Suite for Multiphysics Simulation and Design
https://su2code.github.io
Other
1.36k stars 843 forks source link

Feature turbo interfaces #2349

Closed joshkellyjak closed 1 month ago

joshkellyjak commented 2 months ago

Proposed Changes

There were some merge issues in the previous pull request that were causing lots of issues in #2209. Hopefully this is resolved here.

Update to the interface initialisation to enable both mixing plane and sliding interfaces within the same turbomachinery simulation. Addition of mass flow outlet to Giles BC.

Related Work

This issue solves a problem reported by a number of users, when simulating radial turbomachinery cases a second-order accurate solution cannot be achieved in some cases when using mixing plane interfaces. This is due to circumfrential averaging in regions where the flow exhibits large circumfrential nonuniformity and/or interspace gaps between adjacent blade-rows/zones small. This issue has been reported by @LorenzoFabris, in a presentation at the SU2 Conference 2022 "Performance Analysis and Shape Optimization of a Radial Compressor with the Open-Source Software SU2" and by myself.

Mass flow outlet included in the PR as requested by users.

PR Checklist

Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.

joshkellyjak commented 2 months ago

OK this looks to have solved the merge issues, thanks again @bigfooted @jblueh. Still to do is include the testcase I showed in the developer meetings and update the regression tests due to the bug fix in the mixing plane.