search

subfission / cas

Simple CAS Authentication for Laravel 5 - 10.
MIT License
151 stars 70 forks source link

"Undefined index: cas_client_service" after updating to 4.3.0 #114

Closed dstepe closed 1 year ago

dstepe commented 1 year ago

Thanks for working on support for apereo/phpcas 1.6.0. After updating to subfission/cas 4.3.0 and apereo/cas 1.6.0, I'm getting:

ErrorException (E_NOTICE)
Undefined index: cas_client_service

at https://github.com/subfission/cas/blob/master/src/Subfission/Cas/CasManager.php#L121

I see that the $service_base_url parameter was added to the phpCAS client method in the 1.6.0 release. Is that the reason for the addition here?

I did see your question regarding testing CAS auth. I expect that will be a challenge. Do you have any tests planned for this package yet? I don't see any tests in the project.

dstepe commented 1 year ago

Please see #115

I think release 4.3.0 should be pulled and support for apereo/phpcas limited to 1.5.0 for now.