Request: Option to not create the top and associated geometry

sIKE23 commented 6 years ago

Many boxes that are made do not have tops. It would be very nice to have all four sides and the bottom auto generated. Thanks in advance!

subhero24 commented 6 years ago

I needed this too, but i just generated a bigger box and cut of the top with the boolean tools. But it would indeed be less of a hassle if the option was there. I will look into it ...

subhero24 commented 6 years ago

Option to create open boxes has been added

sIKE23 commented 6 years ago

Wow that was fast! Thanks for the fantastic response. Next, I thought a toolbar button would be nice. I am starting the slow process of learning Ruby so I did a little digging and came up with this: (didn't feel like going though all of the rig-a-ramole to clone/fork/pull request your repo)

if not file_loaded?(FILE) menu = UI.menu('Plugins') menu.add_item('BoxMaker') { self.make_box } toolbar = UI::Toolbar.new "Box Maker" cmd = UI::Command.new("Create Box") { self.make_box } path = Sketchup.find_support_file "CreateBox.png", "plugins/box-maker/Images/" cmd.small_icon = path cmd.large_icon = path cmd.tooltip = "Make a box! Fast! Easy!" cmd.status_bar_text = "This is a plugin for Sketchup which creates a 3d model of a box that can be laser cut." cmd.menu_text = "Create 3D Box" toolbar = toolbar.add_item cmd toolbar.show file_loaded(FILE) end*

This would replace the code at lines 50 - 53 in main.rb. I also created a quick icon for the toolbar (its attached). After I was done, I realized that I had emulated Box.net colors unintentionally. Just a place holder as I am not the worlds greatest graphic designer. Obviously this is your project use it if you like or don't. Just thought that I would share.

The plugin has its own tool bar button. You can enable it via View > Toolbars... > Box Maker. The toolbar button reads 'BOX':

//FC

On Wed, Sep 5, 2018 at 6:53 PM, subhero24 notifications@github.com wrote:

Option to create open boxes has been added

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/subhero24/box-maker/issues/1#issuecomment-418917940, or mute the thread https://github.com/notifications/unsubscribe-auth/AFbmx6ELIZptS3SKGf1fV6ztJ8d864VIks5uYGPwgaJpZM4WZ38j .

subhero24 commented 6 years ago

You're welcome.

Thanks for taking the time to contribute. But if you could please create that pull request though, as I can't find the icon you are referring to.

sIKE23 commented 6 years ago

Ok, I have cloned your repo made my changes and committed them against the master branch. Let me know if that worked or not....

//FC

On Thu, Sep 6, 2018 at 2:15 AM, subhero24 notifications@github.com wrote:

You're welcome.

Thanks for taking the time to contribute. But if you could please create that pull request though, as I can't find the icon you are referring to.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/subhero24/box-maker/issues/1#issuecomment-418990120, or mute the thread https://github.com/notifications/unsubscribe-auth/AFbmx9rXUPy6vi2auDtPkVpHwDJSay4Kks5uYMt6gaJpZM4WZ38j .

subhero24 commented 6 years ago

There is no pull request I'm afraid. You have to fork this repo so you also have a box-maker repository in your github account. Then check it out, make changes to it, commit and push to github. Then you can create the pull request ...

sIKE23 commented 6 years ago

I do not have permissions to update your repo :( my GitHub id is sIKE23.....

On Sat, Sep 8, 2018 at 7:27 AM, subhero24 notifications@github.com wrote:

There is no pull request I'm afraid. You have to fork this repo so you also have a box-maker repository in your github account. Then check it out, make changes to it, commit and push to github. Then you can create the pull request ...

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/subhero24/box-maker/issues/1#issuecomment-419638555, or mute the thread https://github.com/notifications/unsubscribe-auth/AFbmx1DKIUj7KBgdW1dtyKC6OE9m1SRVks5uY7e0gaJpZM4WZ38j .

subhero24 commented 6 years ago

You do not need to update my repo. Fork this repo (not clone!) so you have the box-maker repository of your own. Then make changes to it and push to github. It is your repository then, so you have permission to do what you want. Then you can create a pull request so submit your changes to my repository.

sIKE23 commented 6 years ago

I did this yesterday, let me know if you have any questions.

//FC

On Sun, Sep 9, 2018 at 4:53 AM, subhero24 notifications@github.com wrote:

You do not need to update my repo. Fork this repo (not clone!) so you have the box-maker repository of your own. Then make changes to it and push to github. It is your repository then, so you have permission to do what you want. Then you can create a pull request so submit your changes to my repository.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/subhero24/box-maker/issues/1#issuecomment-419703766, or mute the thread https://github.com/notifications/unsubscribe-auth/AFbmxxHjQ4JqDzQ0ry6w5cq2jq9z4rYtks5uZOUWgaJpZM4WZ38j .

subhero24 / box-maker

Request: Option to not create the top and associated geometry #1