search

subtheme-dev / monokai-pro

The unofficial Monokai Pro theme by Subtheme.
https://subtheme.dev/monokai-pro
MIT License
135 stars 28 forks source link

New UI Compatibility #44

Open kawazoe opened 2 years ago

kawazoe commented 2 years ago

I was testing the New UI beta and noticed that a lot of tool windows from this theme do not have the correct background. I haven't seen this issue with the other themes I've tested (including nightfall and One Dark) so I thought I'd flag it even though it's still in beta.

Actual: Affected tool windows (in WebStorm)

image

All of them use the default background color #2D2A2E instead of the list background color #221F22 making the content a bit difficult to read. I've also notice this happening in some plugins like the TeamCity tool window, suggesting that there might be some global default to set all of them correctly.

Expected: Tool windows that appear to behave correctly (in WebStorm)

image

[1] Small note. After a restart, this stopped working for a reason. Now all modes behave the same (badly). Weird....

kawazoe commented 2 years ago

Another issue I have noticed is that heading texts are very dim which can be awkward when they are used for buttons like on the various tabs displayed in the IDE (see my previous screenshots) as they look like they are disabled buttons.

espositocode commented 1 year ago

Late to respond, but thanks for putting this on my radar. I will look into this.

albyrock87 commented 1 year ago

The same problem affects also the other variants like "Spectrum". DataGrip has the same issue. Thanks for this great theme!

HikaruHokkyokusei commented 1 year ago

If I remember correctly, I have put a fix for this in the existing pending PR.