succinctlabs / sp1

The fastest, most feature-complete zkVM for developers.
https://succinctlabs.github.io/sp1
Apache License 2.0
1.02k stars 340 forks source link

fix: ecdsa recovery failure may cause executor to panic #1799

Closed nhtyy closed 1 week ago

nhtyy commented 1 week ago

in tandem with: https://github.com/sp1-patches/signatures/pull/7/files

github-actions[bot] commented 1 week ago

SP1 Performance Test Results

Branch: n/fix-ecdsa-hook-v3 Commit: b1302105 Author: nhtyy

program cycles execute (mHz) core (kHZ) compress (KHz) time success
fibonacci 11291 0.19 2.84 0.45 25s
ssz-withdrawals 2757356 10.73 116.44 38.31 1m12s
tendermint 12593597 5.41 230.21 105.12 2m2s