Improve detection of ard-reset-arduino location

sudar / Arduino-Makefile

Makefile for Arduino sketches. It defines the workflows for compiling code, flashing it to Arduino and even communicating through Serial.

http://hardwarefun.com/tutorials/compiling-arduino-sketches-using-makefile

GNU Lesser General Public License v2.1

2.02k stars 448 forks source link

Improve detection of ard-reset-arduino location #646

Closed kpfleming closed 4 years ago

kpfleming commented 4 years ago

Find location of ard-reset-arduino before prefixing it with PYTHON_CMD (so that 'which' failure can be detected). Also display the resulting RESET_CMD, or user-provided RESET_CMD.

Prior to this patch the ifndef ARD_RESET_ARDUINO would never be triggered because ARD_RESET_ARDUINO contained the value of PYTHON_CMD, even if the 'which' operation failed.

sej7278 commented 4 years ago

yup, got you - it'll always be defined as it contains PYTHON_CMD, good spot, merged thanks

kpfleming commented 4 years ago

Thanks! I couldn't figure out why 'make upload' always had an empty reset command :-)

With this patch merged and the other two you merged over the past day, I now have an MKR1010WiFi project working perfectly with Arduino-Makefile... build, upload, and monitor. The only remaining things I need the IDE for are updating the toolchains and libraries, and OTA uploads.

sej7278 commented 4 years ago

oh good, i was going to ask if the merges had fixed your wifi build :+1: