search

sudara / melatonin_inspector

A JUCE module that gives you the ability to inspect and visually edit (non-destructively) components in your UI.
MIT License
145 stars 17 forks source link

Modify ci.yml 'on' to run on pull request; Add Linux #100

Closed baconpaul closed 7 months ago

baconpaul commented 7 months ago

Closes #93

Lets see if this works!

baconpaul commented 7 months ago

There you go! This is now running the CI on a PR

baconpaul commented 7 months ago

OK re-pushed to add ubuntu also. Lets see!

sudara commented 7 months ago

This is now running the CI on a PR

To a be a jerk, it probably was going to work anyway, as you were no longer a first time contributor!

But you are right, pull_request was removed here, maybe due to some annoyance with it firing twice with push sometimes?

OK re-pushed to add ubuntu also.

letsgooooo, going for gold!!!

baconpaul commented 7 months ago

yeah lemme try a bit!

sudara commented 7 months ago

i think that warning/error was mentioned here: https://github.com/sudara/melatonin_inspector/issues/93#issuecomment-1735496758

I thiiiink related to the precompiled binary asset stuff — it might need a bit of cleanup, but lol, surprise it's managed by copy_cmake_assets.rb

baconpaul commented 7 months ago

OK looks like that will work. let me squash it and rewrite the comment.

baconpaul commented 7 months ago

OK this is ready!

baconpaul commented 7 months ago

Oooh actually hold on a second.

baconpaul commented 7 months ago

So the precompiled thing. You are treating them as part of your main module whereas juce cmake usually makes them a separate library it compiles itself (with different flags). So it ejects code which doesn't work with error and standard juce warnings.

That's OK though. You can wrap the inclusion of the CPP in a suppress-that-error GCC block I think and have a change to do that

Add edgeGap -> _edgeGap in the ctor argument and in theory you can run linux CI with warnings are errors on.

Lets see!

baconpaul commented 7 months ago

OK now this is really really good to go! :)