sudara / melatonin_perfetto

Use google's perfetto performance tracing in JUCE plugins and apps
45 stars 8 forks source link

Alert when perfetto is enabled #5

Open sudara opened 1 year ago

sudara commented 1 year ago

It's easy to forgot to leave perfetto "on".

Since we often want to trace in release, this can be bad.

In the readme i suggest adding a test to CI to confirm it wasn't left on.

However, perhaps we should at least be alerting via DBG or that perfetto is enabled and how much memory was allocated?

benthevining commented 1 year ago

Doesn't JUCE provide a macro to print a custom compiler warning or message? We could use that to print whether or not Perfetto is enabled.

Or do you mean to print this information during CMake configure-time?

sudara commented 1 year ago

I was thinking run time. However, since most profiling is done in release I guess that rules out DBG's usefulness... Configure time will probably get lost... compile time works!

I added something in my UI, just because it's easy to forget...

AudioPluginHost - 2022-12-12 16@2x
benthevining commented 1 year ago

That's a good idea! The module could also provide something like a PerfettoStatusLabel widget