sufone / qawl

đź“– Quran Reader for Linux, Windows, macOS
https://qawl.app
GNU Affero General Public License v3.0
82 stars 11 forks source link

Use platform native icons and other build assets #54

Closed mr-islam closed 3 years ago

mr-islam commented 3 years ago

Like #41

Low priority, relatively, but important for a good experience.

Just need to read a lot of documentation from https://electron.build, and convert/resize assets and put them in the right palce

mr-islam commented 3 years ago

The most recent attempt didn't work… need to try specify build in the config's icon paths: **build**/icon.ico

I think the location of the icon files are fine… but are they not being included in the final build? The docs say: "Please note — build resources is not packed into the app. If you need to use some files, e.g. as tray icon, please include required files explicitly: "files": ["*/", "build/icon.*"]"

So maybe these assets should be in the public directory? but then what's the point of a build directory? Sigh

mr-islam commented 3 years ago

I'm so annoyed at this issue, and it's also incredibly slow to debug and test and build every time, across three platforms.

Let's get this done because I want the icon to work!

Looking at old Qawl, the assets are in a build directory with no non-default config for builder (regarding icons)

So what's the issue? Let's take this process step by step for all platforms

mr-islam commented 3 years ago

Just spent 2+ hours reading documentation, seeing other codebases, reading Github issues—still can't get the Linux window icon set correctly. I'm considering trying out a different builder completely, because I'm not very happy with the documentation for electron-builder. So I'm creating #62 to try forge / packager.

Will still try and get the icon set right for Windows & macOS, inshaAllah. So Linux it going back to it's own issue for later: #41