search

sugarlabs / cartoon-builder

GNU General Public License v2.0
1 stars 9 forks source link

Port To TelepathyGLib and Python 3 #8

Closed Creatune closed 4 years ago

Creatune commented 4 years ago

@quozl @walterbender @pro-panda @tchx84 @chimosky Please let me know if there are any pending changes.

Aniket21mathur commented 4 years ago

@Creatune did you tested these changes? I reviewed, and not able to figure out how from collabwrapper.collabwrapper import CollabWrapper will work?

Creatune commented 4 years ago

Yes I did test. Currently I claimed the port to TelepathyGLib task, so I thought that I can focus on correcting the port to python 3 later. I got an error regarding the import of collabwrapper that there is no such module named 'collabwrapper'. I will try to fix it :) (I guess I just have to install the module)

Creatune commented 4 years ago

Should I create a separate PR for porting to python 3?

Aniket21mathur commented 4 years ago

Should I create a separate PR for porting to python 3?

You can do it in this pr also, it is up to you. But It would be great if we complete the telepathy part before the porting part :-)

Creatune commented 4 years ago

I will create seperate PRs for python and telepathy port. This PR is confusing to test.