Fix: #8 Duplicate alert prompt popup

sugarlabs / cedit-activity

A text editor for sugar.

GNU General Public License v2.0

0 stars 5 forks source link

Fix: #8 Duplicate alert prompt popup #9

Closed rhl-bthr closed 6 years ago

rhl-bthr commented 6 years ago

Fixed in this PR: Duplicate alert prompt popup

Explanation: File chooser prompt has a alert_status field, initialised to zero, which acts as a key to display the prompts.

Tested on: Sugar 0.112. packaged environment (rdesktop). Ubuntu 16.04

rhl-bthr commented 6 years ago

@cristian99garcia, kindly review

cvgarciarea commented 6 years ago

Sorry for not answering before @Pro-Panda, I had a bussy week, thanks for still working on this activity. About your commit, it fix the problem but I think you can add one thing: once I select an existing file the alert shows me the path of the existing file, but when I select another file that path doesn't change, can you fix it?

rhl-bthr commented 6 years ago

@cristian99garcia Thanks for pointing the mistakes

Changes made:

[x] Alerts path gets updated each time

Kindly review at your convenience again

cvgarciarea commented 6 years ago

Great job @Pro-Panda, thanks!