Merge flappy and flappy_birds

sugarlabs / flappy

A python-pygame Flappy Bird clone

GNU General Public License v3.0

2 stars 12 forks source link

Merge flappy and flappy_birds #18

Closed Dimi20cen closed 1 year ago

Dimi20cen commented 1 year ago

Merge flappy with flappy-birds

Add up-arrow key functionality for bird movement
Refine bird rotation for smoother gameplay
Implement a moving background for enhanced visuals
Incorporate flapping wings animation
Adjust the starting point of bottom pipes for better visuals
Enhance collision detection, using masks, for increased precision
Introduce a sound effect upon collision, with the bird falling to the ground
Tweak the points sound effect timing for improved feedback
Update the game font and add an outline, to resemble the original Flappy Bird
Replace the existing Sugargame file with the latest version
Add flake8 file

@chimosky @sourabhaa

chimosky commented 1 year ago

@Dimi20cen I opened a PR in your master branch, couldn't push here as you're working on the master branch.

sourabhaa commented 1 year ago

tested, I'm able to see the toolbar, Screenshot of _Flappy Activity_

jriyyya commented 1 year ago

Tested dec589d, Toolbar is visible and functional to me

chimosky commented 1 year ago

Tested dec589d and the toolbar shows, I'll compare with flappy birds before merging.

chimosky commented 1 year ago

I compared with flappy birds activity and they're a few things left;

[ ] sound; Flappy birds have sound from start of the game till the end of the game.
[ ] Game speed; flappy seems to have a very slow game speed compared to flappy birds and it would be great to increase the game speed as it's more interesting.

Dimi20cen commented 1 year ago

sound; Flappy birds have sound from start of the game till the end of the game.

Could you clarify? I think the merged activity and flappy-birds have, identical sounds.

Game speed; flappy seems to have a very slow game speed compared to flappy birds and it would be great to increase the game speed as it's more interesting.

While x-speed is slower than flappy's, I aimed to mimic the x-speed of the original implementation of the game flappy birds, trusting that they'd found the sweet spot.

chimosky commented 1 year ago

Could you clarify? I think the merged activity and flappy-birds have, identical sounds.

There are no sounds when I test your changes, @jriyyya @sourabhaa was the sound working fine when you tested?

While x-speed is slower than flappy's, I aimed to mimic the x-speed of the original implementation of the game flappy birds, trusting that they'd found the sweet spot.

Okay.

Dimi20cen commented 1 year ago

Sound should be fixed @chimosky.

chimosky commented 1 year ago

Tested c6062e1, sound now works as expected. Thanks!