search

sugarlabs / sugar-docs

Documentation for Contributors and Developers
86 stars 104 forks source link

Corrected the git command in contributing.md file #205

Closed RajatSinghRawat closed 3 years ago

RajatSinghRawat commented 3 years ago

Screenshot (401)

In the second git command you also have to specify the branch-name to which you are pulling the code. And after that you have to push your local repository to the origin, then the remote forked repository will be updated. I have added the command.

RajatSinghRawat commented 3 years ago

@walterbender Please review the changes I have made.

quozl commented 3 years ago

Yes, unless you have configured the branch with a default remote, you will see this message;

You asked to pull from the remote 'upstream', but did not specify
a branch. Because this is not the default configured remote
for your current branch, you must specify a branch on the command line.

But you may not be operating against the master branch. Developers on Sugarizer, for example, will usually be operating from the dev branch. So I don't agree to make this change.

Also, you do not have to push your local repository to the origin. That's something you must choose when to do, and is not part of keeping your fork up to date.

RajatSinghRawat commented 3 years ago

@quozl Thank you sir for reviewing my pull request and letting me know my wrong commit.

quozl commented 3 years ago

I don't understand; what is your counter-offer or next step?