search

sugarlabs / sugar-toolkit-gtk3

Sugar Learning Environment, Activity Toolkit, GTK 3.
GNU Lesser General Public License v2.1
21 stars 80 forks source link

Python3.8 raises critical SyntaxWarnings #434

Closed srevinsaju closed 4 years ago

srevinsaju commented 4 years ago

On Arch, python3 == python3.8 It raises the following tracebacks which would be important, but I am not sure if changing them appropriately would be right

/usr/lib/python3.8/site-packages/sugar3/profile.py:71: SyntaxWarning: "is not" with a literal. Did you mean "!="?
  return nick is not '' and \
/usr/lib/python3.8/site-packages/sugar3/profile.py:72: SyntaxWarning: "is not" with a literal. Did you mean "!="?
  color is not '' and \
/usr/lib/python3.8/site-packages/sugar3/activity/activity.py:1345: SyntaxWarning: "is" with a literal. Did you mean "=="?
  elif display_name is 'Broadway':

(sugar-activity3:16221): Gtk-WARNING **: 13:53:10.710: Theme parsing error: gtk-widgets.css:16:32: The style property GtkExpander:expander-size is deprecated and shouldn't be used anymore. It will be removed in a future version

(sugar-activity3:16221): Gtk-WARNING **: 13:53:10.710: Theme parsing error: gtk-widgets.css:17:35: The style property GtkExpander:expander-spacing is deprecated and shouldn't be used anymore. It will be removed in a future version
quozl commented 4 years ago

Thanks. No need to waste time on adding an issue for something you have a fix for, just make the pull request and make sure the commit message explains the problem.