Fix activity/activity callbacks, and adapt icon.colorize function

sugarlabs / sugar-web

Components for Sugar web activities

Apache License 2.0

13 stars 32 forks source link

Fix activity/activity callbacks, and adapt icon.colorize function #32

Closed manuq closed 11 years ago

manuq commented 11 years ago

Invert the if/else clauses. If the error === null then there was no error.

Change the output of activity.getXOColor to be an object with stroke and fill members instead of an array. Adape icon.colorize function to this change.

manuq commented 11 years ago

Template needs to be adapted too: https://github.com/sugarlabs/sugar-web-template/pull/17

manuq commented 11 years ago

BTW this needs a test. But other tests are failing here, is only me?

dnarvaez commented 11 years ago

Tests seems fine for me and on buildbot. I've seen something weird a couple of days ago... can you try to remove ~/.sugar/default and see if that fixes it? (We shouldn't be running them on the default profile anyway, I need to fix that).

dnarvaez commented 11 years ago

Pushed a js-beautify fix on top of this.

manuq commented 11 years ago

Thanks for the fixes on top, I really missed this time.