sugyan / atrium

Rust libraries for Bluesky's AT Protocol services.
MIT License
218 stars 26 forks source link

atrium-streams + atrium-streams-client implementation #228

Open oestradiol opened 2 months ago

oestradiol commented 2 months ago

This Pull Request adds two new crates:

TODO:

oestradiol commented 2 months ago

Obs.: Refer to https://github.com/sugyan/atrium/pull/223/ for information on name choices, as well as why this Draft was re-created.

oestradiol commented 2 months ago

Force-pushed to re-sync with main.

@sugyan, it seems giraffate/clippy-action@v1 is not causing the workflow to fail whenever there is an error:

Is this expected behaviour?

sugyan commented 2 months ago

I'm not sure since I can't see that event from your link, but it may indeed just be reported and not fail.

I didn't really think much about what should happen at first when I installed it. Now I think... it doesn't have to follow strictly and Not Fail is the expected behavior.

Uinelj commented 1 day ago

To remove transmute you can rely on something similar as what I have done while fixing firehose. I think using some into_raw_parts-like fn rather than .as_bytes could be better but at least we avoid using transmute 🎉

https://github.com/sugyan/atrium/blob/8b8c7fcb6e2a35cf417388174daca468afa6cb1d/examples/firehose/src/cid_compat.rs