Open oestradiol opened 2 months ago
Obs.: Refer to https://github.com/sugyan/atrium/pull/223/ for information on name choices, as well as why this Draft was re-created.
Force-pushed to re-sync with main
.
@sugyan, it seems giraffate/clippy-action@v1
is not causing the workflow to fail whenever there is an error:
main
.Is this expected behaviour?
I'm not sure since I can't see that event from your link, but it may indeed just be reported and not fail.
I didn't really think much about what should happen at first when I installed it. Now I think... it doesn't have to follow strictly and Not Fail is the expected behavior.
To remove transmute
you can rely on something similar as what I have done while fixing firehose
. I think using some into_raw_parts
-like fn rather than .as_bytes
could be better but at least we avoid using transmute 🎉
This Pull Request adds two new crates:
EventStreamClient
,Handlers
andSubscription
defined in atrium-streams for interacting with the variety of subscriptions in ATProto.TODO:
Firehose
implementation + add configurations to manually enable payload types to avoid unnecessary computations;com.atproto.label.subscribeLabels
+ tests;std::mem::transmute
is not recommended. It works wonderfully for now, but eventually it might not anymore. Think of a way to replace the outdated rs_car crate somehow (if possible).