search

suharev7 / clickhouse-rs

Asynchronous ClickHouse client library for Rust programming language.
MIT License
324 stars 121 forks source link

Fix and test TLS build #160

Closed PeterFaiman closed 2 years ago

PeterFaiman commented 3 years ago

It seems like some references to tokio_tls were overlooked when updating the tokio-tls dependency to tokio-native-tls.

The yandex ClickHouse image used for Travis CI doesn't expose TLS ports by default, so I didn't add anything to .travis.yml. But seeing as the TLS build literally had compile errors, perhaps adding cargo build --features tls would be worthwhile?

kamyuentse commented 2 years ago

@suharev7 could you please review and merge this PR?

suharev7 commented 2 years ago

Thanks you

costa commented 1 year ago

Thanks for your work, is this in any version as of this moment?

suharev7 commented 1 year ago

There is currently no version available with this PR. I'll try to release one this week, I think.

costa commented 1 year ago

There is currently no version available with this PR. I'll try to release one this week, I think.

FYI, I've setup a local dependency (off your trunk) and it works with clickhouse.cloud (via TLS) with no apparent issues.

Except (unrelated) Date/Time handling, I had problems with these on the last version and just didn't check if they persist on the current trunk.

suharev7 commented 1 year ago

Version 1.1.0-alpha.1 has been released.

costa commented 1 year ago

@suharev7 Thanks, it works.