search

sul-dlss / dlme

Digital Library of the Middle East web application, based on Spotlight
https://dlmenetwork.org/
Other
20 stars 2 forks source link

Contributor links in contributor page should lead to contributor items only #1349

Closed jacobthill closed 2 years ago

jacobthill commented 3 years ago

If you click on a contributor in the contributors page it leads to a search result for all objects instead of only the objects from that contributor.

Screen Shot 2021-11-08 at 11 51 21 AM
jacobthill commented 2 years ago

Is this supposed to be working in dev or are we waiting on something? I assume its supposed to be working since its in the QA column but let me know if not. Its not currently working. Clicking on 'American Numismatic Society' under 'Data Contributors' produces this url: https://dev.dlmenetwork.org/library/catalog?f%5Bagg_provider.en_ssim%5D%5B%5D=American+Numismatic+Society which returns all resources in the database, instead of only those with agg_provider="American Numismatic Society". The expected url is "https://dev.dlmenetwork.org/library/catalog?f%5Bagg_provider_en%5D%5B%5D=American+Numismatic+Society" or some other equivalent.

Also I just noticed this problem seems to extend to all urls on the conrtibutors page; clicking on a language or object type also returns all objects.

corylown commented 2 years ago

This change is merged into the main branch. I do not believe it is deployed anywhere. I think we need to have some team agreement about process to avoid confusion like this.

jacobthill commented 2 years ago

Found a new bug related to items by type counts, opened https://github.com/sul-dlss/dlme/issues/1436

corylown commented 2 years ago

The fix for this issue is merged into main, deployed to dev, and is working so I am closing this again.

mwerla commented 2 years ago

@jacobthill Looks good to me