search

sulu / SuluArticleBundle

Bundle for managing localized content-rich entities like blog-posts in the Sulu content management system
MIT License
52 stars 77 forks source link

Fix incompatibility with the get_image twig function from sulu/web-twig package #671

Closed dev-newvisibility closed 3 weeks ago

dev-newvisibility commented 3 months ago
Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Fixed tickets fixes #issuenum
Related issues/PRs #issuenum
License MIT

What's in this PR?

We've noticed that icons and images from the article excerpt are not compatible with the twig function get_image of the sulu/web-twig package. This PR fixes that (a re-index is required after applying the patch).

Why?

At the moment every image is treated as a jpeg (including SVG) because the mime type is not indexed in ES.

The ImageExtension needs to know the MIME type of the image in order to render the appropriate html tag: https://github.com/sulu/web-twig/blob/4ed8fda8b0632082ebb16a70c4e94131a9ec648f/src/ImageExtension.php#L571

alexander-schranz commented 3 weeks ago

@dev-newvisibility Thank you!