Closed plozmun closed 3 years ago
Thanks for the PR. Personally, I dont have a strong opinion on what name to use 🙂
@alexander-schranz @Prokyonn Do you remember if there was a reason for using theme.json
instead of composer.json
?
I would still go with the theme.json
as I think the SyliusThemeBundle focus is on providing installable themes which are really need a composer.json
and are packages registered in packagist. But this is not the main usage in sulu case and I think is missleading when a theme lives inside a project to have there composer.json
inside a subfolder which not really have something there.
That's why its documented L73 with setting:
sylius_theme:
sources:
filesystem:
filename: theme.json
I would still go with the
theme.json
as I think the SyliusThemeBundle focus is on providing installable themes which are really need acomposer.json
and are packages registered in packagist. But this is not the main usage in sulu case and I think is missleading when a theme lives inside a project to have therecomposer.json
inside a subfolder which not really have something there.That's why its documented L73 with setting:
sylius_theme: sources: filesystem: filename: theme.json
Wops! my bad , i didn't see that in configuration, sorry
What's in this PR?
SyliusThemeBundle doesn't use theme.json